Potential missing semicolon or {} after while statement in startup.c

[shawn]

I just filed this:

Potential missing end-while-loop semicolon or {} · Issue #802 · PaulStoffregen/cores

cores/teensy4/startup.c Line 698 in 7f107ee while (PIT_TFLG0 == 0) /* wait 0.1 second for PC to know USB unplugged */ Is the while statement missing a semicolon or "{}"? Otherwise, the SRC_GPR5 = 0...

github.com

There's a potential missing semicolon or while loop body in startup.c. Unless the SRC_GPR5 = 0x0BAD00F1; statement is meant to be inside the loop, which I don't think it is.

 

[CollinK]

This seems to be an interesting case where, yes, it appears there should have been a semicolon but it is of no actual importance that there wasn't. I don't see any harm in the code as-is but also it seems incorrect. What an odd situation!

 

[MarkT]

It is a structural error, whether benign or not it should be fixed to prevent confusion in the future...