Mcu32
Well-known member
may cause clicks:
the buffer is 2*int16 (stereo), so usb_audio_transmit_buffer + len*2 would be correct.
the buffer is 2*int16 (stereo), so usb_audio_transmit_buffer + len*2 would be correct.
Well, we have this post. Of course, we were previously told 1.61, it didn’t make it to 1.62, and 1.63 hasn’t started yet. I’m definitely not holding my breath, but it is getting a reasonable amount of traffic here, and there’s a fair few people who want it, let alone all those who would simply be content with working stereo, rather than the glitch-prone implementation we’re currently stuck with.Do you see any chance that this will ever be merged?
That would be great. The earlier any required fixes get in there, the less likely it is to get kicked out of the 1.63 campaign and have to wait for yet another cycle before it’s considered.I'd be happy to take a look over the next few days if you want.
I have to correct this; there is no read.another: in copytobuffers:
uint32_t *target = (uint32_t*) src + len;
[...]
while ((src < target - 2))
[..] src gets read. but with len=1 at a negative index.
may cause clicks, too + undefined behaviour.