bmillier
Well-known member
I am using Version Teensy 1.29
In my tests (using audio shield and a guitar signal) , the flange effect does not produce the correct "sweeping comb-filter" effect that it should. I have traced the problem to the following lines in effect_flange.cpp
in AudioEffectFlange.begin routine:
line 80 delay_rate_incr = delay_rate / (2147483648.0 * AUDIO_SAMPLE_RATE_EXACT)
and similarly in AudioEffectFlange.voices routine:
line 105 delay_rate_incr = delay_rate / (2147483648.0 * AUDIO_SAMPLE_RATE_EXACT)
delay_rate_incr is an int type. For any normal values of delay_rate in Hz ( i.e 0.5 Hz, as in example Sketch) , this will evaluate to
a tiny fraction which will evaluate to 0 for an integer type. So, BOTH of these lines should both be replaced with
delay_rate_incr =(delay_rate * 2147483648.0)/ AUDIO_SAMPLE_RATE_EXACT;
After modifying this file, the flange effect tested out properly for me.
I only started using Teensy/Audio board a few weeks ago, and am not sure the right way to report this to Paul ( a github notification perhaps??)
Overall I think the Audio Designer/ library is excellent.
In my tests (using audio shield and a guitar signal) , the flange effect does not produce the correct "sweeping comb-filter" effect that it should. I have traced the problem to the following lines in effect_flange.cpp
in AudioEffectFlange.begin routine:
line 80 delay_rate_incr = delay_rate / (2147483648.0 * AUDIO_SAMPLE_RATE_EXACT)
and similarly in AudioEffectFlange.voices routine:
line 105 delay_rate_incr = delay_rate / (2147483648.0 * AUDIO_SAMPLE_RATE_EXACT)
delay_rate_incr is an int type. For any normal values of delay_rate in Hz ( i.e 0.5 Hz, as in example Sketch) , this will evaluate to
a tiny fraction which will evaluate to 0 for an integer type. So, BOTH of these lines should both be replaced with
delay_rate_incr =(delay_rate * 2147483648.0)/ AUDIO_SAMPLE_RATE_EXACT;
After modifying this file, the flange effect tested out properly for me.
I only started using Teensy/Audio board a few weeks ago, and am not sure the right way to report this to Paul ( a github notification perhaps??)
Overall I think the Audio Designer/ library is excellent.