Forum Rule: Always post complete source code & details to reproduce any issue!
Results 1 to 7 of 7

Thread: Audio Designer Flange effect not working- solved

  1. #1
    Senior Member bmillier's Avatar
    Join Date
    Apr 2016
    Location
    Halifax, N.S. Canada
    Posts
    185

    Audio Designer Flange effect not working- solved

    I am using Version Teensy 1.29

    In my tests (using audio shield and a guitar signal) , the flange effect does not produce the correct "sweeping comb-filter" effect that it should. I have traced the problem to the following lines in effect_flange.cpp
    in AudioEffectFlange.begin routine:

    line 80 delay_rate_incr = delay_rate / (2147483648.0 * AUDIO_SAMPLE_RATE_EXACT)

    and similarly in AudioEffectFlange.voices routine:

    line 105 delay_rate_incr = delay_rate / (2147483648.0 * AUDIO_SAMPLE_RATE_EXACT)

    delay_rate_incr is an int type. For any normal values of delay_rate in Hz ( i.e 0.5 Hz, as in example Sketch) , this will evaluate to
    a tiny fraction which will evaluate to 0 for an integer type. So, BOTH of these lines should both be replaced with

    delay_rate_incr =(delay_rate * 2147483648.0)/ AUDIO_SAMPLE_RATE_EXACT;

    After modifying this file, the flange effect tested out properly for me.
    I only started using Teensy/Audio board a few weeks ago, and am not sure the right way to report this to Paul ( a github notification perhaps??)
    Overall I think the Audio Designer/ library is excellent.

  2. #2
    Senior Member+ Frank B's Avatar
    Join Date
    Apr 2014
    Location
    Germany NRW
    Posts
    5,679
    I can do a pull-request @ github for you.

  3. #3
    Senior Member+ Frank B's Avatar
    Join Date
    Apr 2014
    Location
    Germany NRW
    Posts
    5,679

  4. #4
    Senior Member bmillier's Avatar
    Join Date
    Apr 2016
    Location
    Halifax, N.S. Canada
    Posts
    185
    Thanks a lot Frank. In the past I did most of my programming on my own and didn't need to use github. Now that I am getting more involved in "crowd-sourced" software/libraries, I'll have to learn to do more with github than just download other peoples libraries.
    From the large amount of work you do with Teensy, that I see in the forum, I am guessing that there are more than 24 hours/day in Germany.

  5. #5
    Senior Member
    Join Date
    Nov 2012
    Posts
    1,178
    @bmillier: thanks for finding and fixing that bug. And @Frank B: thanks for doing the PR for it.

    Pete

  6. #6
    Senior Member bmillier's Avatar
    Join Date
    Apr 2016
    Location
    Halifax, N.S. Canada
    Posts
    185
    @pete. You're welcome. The flange effect works great, quite like the plug-in that I have in my PC DAW software. I think I will take a look at the chorus effect as it seems pretty "flat" . I believe it needs a small amount of random delay modulation to sound right, which may or may not be in there now.
    Thanks for your coding effort on the audio library.

  7. #7
    Member
    Join Date
    Nov 2015
    Location
    Norway
    Posts
    70
    actually it would be nice to have a modulation input in addition to the audio signal both on the chorus and the flanger. Where you could connect a low frequency signal into. That way the effects can be really interesting and you can easy edit the width and tone of them. Don't know if this is easy. Will try to look at it..

    ...and it would also be REALLY nice to have a modulation input on the delay. Where the input (0-1) could set the delaytime between two limits. This is a buildingblock for a lot of cool effects like detune, reverb and pitchshifting. probalby harder to make then the modulationinput on the chorus and flanger.
    Last edited by omjanger; 10-23-2016 at 11:51 PM.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •