Forum Rule: Always post complete source code & details to reproduce any issue!
Page 2 of 2 FirstFirst 1 2
Results 26 to 29 of 29

Thread: Probable race condition in Radiohead library

  1. #26
    Junior Member
    Join Date
    Nov 2015
    Location
    colorado
    Posts
    17
    Paul,

    Arduino 1.8.2 w/ teensyduino 1.36.b4, teensy 3.2 w/ RFM95 lora 433. No problems with the teensy-supplied library.

    IMO, the rising vs high "fix" is simply narrowing an already small timing window. It's not a fix, but a bandaid that's sure to cause problems later. The proper fix is in the code that you have incorporated in 1.36.b4.

    David

  2. #27
    Senior Member PaulStoffregen's Avatar
    Join Date
    Nov 2012
    Posts
    14,249
    KurtE really deserves the credit for this fix.

    Thanks for testing. It's a huge help!

  3. #28
    Senior Member KurtE's Avatar
    Join Date
    Jan 2014
    Posts
    2,330
    Thanks,

    It is a group effort. The race condition was fixed by dgranger.

    Warning, the fix eas only done for the RFM95 portion. My guess tells me, that similar changes may be needed for other radios as well.

  4. #29
    Member tcottle's Avatar
    Join Date
    Dec 2014
    Location
    Longmont, CO
    Posts
    27
    Arduino 1.8.2, Teensy 3.2 @ 96MHz, Teensyduino 1.36b4, Radiohead library supplied w/ Teensyduino

    >1,000 TX cycles without lockup. Also removed the 10ms delays and 1S pacing delay in the main loop of the sketch in post 1

    Thanks Paul, KurtE, dgranger and others!

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •