KurtE
Senior Member+
@MichaelMeissner @PaulStoffregen @mjs513 @defragster ... - Wondering how much to do with this library (teensy_ssd1351) which installs with Teensyduino as just ssd1351?
That is it was originally done by the member @kirberich - Last change was back in 2016 and it looks like he has not been up on forum since April 2017.
I have it running now on T4... I am playing with the UnCannyEyes to see how fast this library would make it versus the Adafruit library...
I agree with Michael, that the library names confusion would be nice to avoid...
Also this library is not overly compatible with the Adafruit_ssd1351 library. That is unlike some of the others where we can get away with maybe only changing which object we are using and maybe changes on constructor and/or init member... There are lots of differences. Things like:
Object definitions: Instead of something like:
you have something like:
Which is easy enough to deal with... They both have the same begin()... So again not an issue.
This library does not support: setRotation()
In UnCannyEyes - there is the issue that most of the primitives take a specific object type for color, instead of an something like uint16_t.
So for example: fillScreen(0);
Needs to be changed to something like: fillScreen(ssd1351::RGB(0, 0,0));
So question would be: how much to play here? I may do a little more hacking here to see how bad the changes to uncanny would be...
Again wondering with libraries like this to support displays where the originators are no longer active what to do?
Hopefully when I issue a PR, he might accept it. Looks like his github account is still active.
That is it was originally done by the member @kirberich - Last change was back in 2016 and it looks like he has not been up on forum since April 2017.
I have it running now on T4... I am playing with the UnCannyEyes to see how fast this library would make it versus the Adafruit library...
I agree with Michael, that the library names confusion would be nice to avoid...
Also this library is not overly compatible with the Adafruit_ssd1351 library. That is unlike some of the others where we can get away with maybe only changing which object we are using and maybe changes on constructor and/or init member... There are lots of differences. Things like:
Object definitions: Instead of something like:
Code:
Adafruit_SSD1351 tft = Adafruit_SSD1351(SCREEN_WIDTH, SCREEN_HEIGHT, CS_PIN, DC_PIN, MOSI_PIN, SCLK_PIN, RST_PIN);
you have something like:
Code:
auto display = ssd1351::SSD1351<ssd1351::HighColor, ssd1351::SingleBuffer, 128, 128>(CS_PIN, DC_PIN, RST_PIN);
Which is easy enough to deal with... They both have the same begin()... So again not an issue.
This library does not support: setRotation()
In UnCannyEyes - there is the issue that most of the primitives take a specific object type for color, instead of an something like uint16_t.
So for example: fillScreen(0);
Needs to be changed to something like: fillScreen(ssd1351::RGB(0, 0,0));
So question would be: how much to play here? I may do a little more hacking here to see how bad the changes to uncanny would be...
Again wondering with libraries like this to support displays where the originators are no longer active what to do?
Hopefully when I issue a PR, he might accept it. Looks like his github account is still active.