Unbalanced Parentheses in imxrt.h

sig11

Member
Hi,

parsing the file for vaguely related purposes I received a not completely unjustified error message.

Here's the diff:

Code:
2131c2131
< #define IMXRT_DMA_TCD		((IMXRT_DMA_TCD_t *)(IMXRT_DMA_ADDRESS+0x1000)
---
> #define IMXRT_DMA_TCD		((IMXRT_DMA_TCD_t *)(IMXRT_DMA_ADDRESS+0x1000))

might be worth fixing
 
Opps, fixed.

https://github.com/PaulStoffregen/cores/commit/6b5ba2decf526d14ae0ef04dc6a32e2edbdcc4e1

Also added this comment to explain the typical way TCD registers are accessed.

Code:
// Normally these Transfer Control Descriptor (TCD) registers are accessed through
// DMAChannel instances.  See DMAChannel.h for details.  Or refer to libraries which
// use DMA (OctoWS2811, Audio, WS2812Serial, SmartMatrix, ILI9341_t3n, etc).
// When you access TCD registers directly, you must edit all DMA-using code to
// assure no conflicts among which of the 32 TCDs are used.  DMAChannel allocates
// channels automatically, to avoid TCD usage conflicts.
 
Back
Top